[
https://issues.apache.org/jira/browse/FLINK-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565187#comment-16565187
]
ASF GitHub Bot commented on FLINK-9946:
---------------------------------------
zentol closed pull request #6433: [FLINK-9946][tests] Expose Flink version to
E2E tests
URL: https://github.com/apache/flink/pull/6433
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/flink-end-to-end-tests/test-scripts/common.sh
b/flink-end-to-end-tests/test-scripts/common.sh
index 621db11e824..bd9a8537d38 100644
--- a/flink-end-to-end-tests/test-scripts/common.sh
+++ b/flink-end-to-end-tests/test-scripts/common.sh
@@ -36,6 +36,8 @@ export EXIT_CODE=0
echo "Flink dist directory: $FLINK_DIR"
+FLINK_VERSION=$(cat ${END_TO_END_DIR}/pom.xml | sed -n
's/.*<version>\(.*\)<\/version>/\1/p')
+
USE_SSL=OFF # set via set_conf_ssl(), reset via revert_default_config()
TEST_ROOT=`pwd -P`
TEST_INFRA_DIR="$END_TO_END_DIR/test-scripts/"
diff --git a/flink-end-to-end-tests/test-scripts/test_quickstarts.sh
b/flink-end-to-end-tests/test-scripts/test_quickstarts.sh
index d17a3ba6b43..12cd04fa01f 100755
--- a/flink-end-to-end-tests/test-scripts/test_quickstarts.sh
+++ b/flink-end-to-end-tests/test-scripts/test_quickstarts.sh
@@ -46,7 +46,7 @@ ARTIFACT_VERSION=0.1
mvn archetype:generate \
-DarchetypeGroupId=org.apache.flink \
-DarchetypeArtifactId=flink-quickstart-${TEST_TYPE} \
- -DarchetypeVersion=1.7-SNAPSHOT \
+ -DarchetypeVersion=${FLINK_VERSION} \
-DgroupId=org.apache.flink.quickstart \
-DartifactId=${ARTIFACT_ID} \
-Dversion=${ARTIFACT_VERSION} \
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Quickstart E2E test archetype version is hard-coded
> ---------------------------------------------------
>
> Key: FLINK-9946
> URL: https://issues.apache.org/jira/browse/FLINK-9946
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.6.0, 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> {code}
> mvn archetype:generate \
> -DarchetypeGroupId=org.apache.flink \
> -DarchetypeArtifactId=flink-quickstart-${TEST_TYPE} \
> -DarchetypeVersion=1.6-SNAPSHOT \
> -DgroupId=org.apache.flink.quickstart \
> -DartifactId=${ARTIFACT_ID} \
> -Dversion=${ARTIFACT_VERSION} \
> -Dpackage=org.apache.flink.quickstart \
> -DinteractiveMode=false
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
