[
https://issues.apache.org/jira/browse/FLINK-9963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565436#comment-16565436
]
ASF GitHub Bot commented on FLINK-9963:
---------------------------------------
twalthr commented on a change in pull request #6447: [FLINK-9963] [table] Add a
string table format factory
URL: https://github.com/apache/flink/pull/6447#discussion_r206907666
##########
File path: flink-formats/flink-string/pom.xml
##########
@@ -0,0 +1,112 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements. See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership. The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied. See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/maven-v4_0_0.xsd";>
+
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-formats</artifactId>
+ <version>1.7-SNAPSHOT</version>
+ <relativePath>..</relativePath>
+ </parent>
+
+ <artifactId>flink-string</artifactId>
Review comment:
We don't need a special module for this as it does not add dependencies. We
can put it under `org.apache.flink.table.formats`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add a string table format factory
> ---------------------------------
>
> Key: FLINK-9963
> URL: https://issues.apache.org/jira/browse/FLINK-9963
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Ruidong Li
> Priority: Major
> Labels: pull-request-available
>
> Sometimes it might be useful to just read or write a string into Kafka or
> other connectors. We should add a simple string
> {{SerializationSchemaFactory}} and {{DeserializationSchemaFactory}}. How we
> want to represent all data types and nested types is still up for discussion.
> We could also support just a single string field?
> Schema derivation should be supported by the factories.
> See {{org.apache.flink.formats.json.JsonRowFormatFactory}} for a reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
