tzulitai commented on a change in pull request #6467: [FLINK-9887] Ensure
serializer upgrades work with timer service remake
URL: https://github.com/apache/flink/pull/6467#discussion_r207161334
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TimerSerializer.java
##########
@@ -208,8 +215,35 @@ public TypeSerializerConfigSnapshot
snapshotConfiguration() {
@Override
public CompatibilityResult<TimerHeapInternalTimer<K, N>>
ensureCompatibility(
TypeSerializerConfigSnapshot configSnapshot) {
- //TODO this is just a mock (assuming no serializer updates) for
now and needs a proper implementation! change this before release.
- return CompatibilityResult.compatible();
+
+ if (configSnapshot instanceof
CompositeTypeSerializerConfigSnapshot) {
Review comment:
should this actually be `configSnapshot instanceof
TimerSerializerConfigSnapshot`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
