[
https://issues.apache.org/jira/browse/FLINK-9947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566572#comment-16566572
]
ASF GitHub Bot commented on FLINK-9947:
---------------------------------------
fhueske commented on a change in pull request #6456: [FLINK-9947] [docs]
Document unified table sources/sinks/formats
URL: https://github.com/apache/flink/pull/6456#discussion_r207137949
##########
File path: docs/dev/table/connect.md
##########
@@ -67,14 +67,24 @@ This table is only available for stable releases.
Overview
--------
-Beginning from Flink 1.6, the declaration of a connection to an external
system is separated from the actual implementation. Connections can be
specified either
+Beginning from Flink 1.6, the declaration of a connection to an external
system is separated from the actual implementation.
+
+Connections can be specified either
- **programmatically** using a `Descriptor` under
`org.apache.flink.table.descriptors` for Table & SQL API
- or **declaratively** via [YAML configuration files](http://yaml.org/) for
the SQL Client.
-This allows not only for better unification of APIs and SQL Client but also
for better extensibility in case of [custom implementations](sourceSinks.html)
without changing the declaration.
+This allows not only for better unification of APIs and SQL Client but also
for better extensibility in case of [custom implementations](sourceSinks.html)
without changing the actual declaration.
+
+Every declaration is similar to a SQL `CREATE TABLE` statement. One can define
the name of the table, the final schema of the table, a connector, and a data
format upfront for connecting to an external system.
Review comment:
I would remove the `final` from `final schema`. Otherwise users might ask
themselves if there is an intermediate schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Document unified table sources/sinks/formats
> --------------------------------------------
>
> Key: FLINK-9947
> URL: https://issues.apache.org/jira/browse/FLINK-9947
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> The recent unification of table sources/sinks/formats needs documentation. I
> propose a new page that explains the built-in sources, sinks, and formats as
> well as a page for customization of public interfaces.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
