fhueske commented on a change in pull request #6456: [FLINK-9947] [docs] Document unified table sources/sinks/formats URL: https://github.com/apache/flink/pull/6456#discussion_r207151835
########## File path: docs/dev/table/connect.md ########## @@ -215,9 +227,9 @@ If no factory can be found or multiple factories match for the given properties, Table Schema ------------ -The table schema allows for describing the final appearance of a table. It specifies the final name, final type, and the origin of a field. The origin of a field might be important if the name of the field should differ from the input/output format. For instance, a field `name&field` should reference `nameField` from an Avro format. Additionally, the schema is needed to map column names and types from an external system to Flink's representation. In case of a table sink, it ensures that only data with valid schema is written to an external system. +The table schema defines the final appearance of a table. It specifies the name, type, and the origin of a field. The origin of a field might be important if the name of the field should differ from the input/output format. For instance, a field `user_name` should reference `$$-user-name` from a JSON format. Additionally, the schema is needed to map column names and types from an external system to Flink's representation. In case of a table sink, it ensures that only data with valid schema is written to an external system. Review comment: I would remove `final` here as well. A table does not have an intermediate schema or appearance. Maybe rephrase to something like: `The table schema defines the names and types of the fields of a table similar to the field definitions of a SQL CREATE TABLE statement. In addition, can specify how fields are mapped from and to the format in which the table data is encoded. For instance, a field user_name ...` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
