twalthr commented on a change in pull request #6223: [FLINK-9688] [table] ATAN2
sql function support
URL: https://github.com/apache/flink/pull/6223#discussion_r207212692
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/mathExpressions.scala
##########
@@ -243,6 +243,19 @@ case class Atan(child: Expression) extends
UnaryExpression {
}
}
+case class Atan2(left: Expression, right: Expression) extends BinaryExpression
with InputTypeSpec {
Review comment:
We should not use `InputTypeSpec` here. It forces a certain type which
results in BigDecimal even for double types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
