[
https://issues.apache.org/jira/browse/FLINK-7812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16566837#comment-16566837
]
ASF GitHub Bot commented on FLINK-7812:
---------------------------------------
zentol commented on a change in pull request #4801: [FLINK-7812] Log system
resources metrics
URL: https://github.com/apache/flink/pull/4801#discussion_r207230429
##########
File path:
flink-tests/src/test/java/org/apache/flink/runtime/taskexecutor/SystemResourcesMetricsITCase.java
##########
@@ -33,13 +33,13 @@
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
+import static
org.apache.flink.configuration.CoreOptions.SYSTEM_RESOURCE_METRICS;
import static org.apache.flink.configuration.MetricOptions.REPORTERS_LIST;
-import static
org.apache.flink.configuration.TaskManagerOptions.ADDITIONAL_LOGGING;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
/**
- * Integration tests for proper initialization of the system resource metrics
in the {@link TaskManagerRunner}.
+ * Integration tests for proper initialization of the system resource metrics.
Review comment:
This test should be updated to check that they are reported for both JM and
TM.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Log system resources as metrics
> -------------------------------
>
> Key: FLINK-7812
> URL: https://issues.apache.org/jira/browse/FLINK-7812
> Project: Flink
> Issue Type: New Feature
> Components: Metrics
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
