tillrohrmann opened a new pull request #6479: [FLINK-9969][batch] Dispose InMemorySorters created by the UnilateralSortMerger URL: https://github.com/apache/flink/pull/6479 ## What is the purpose of the change This commit changes the behaviour of the UnilateralSortMerger to keep references of the created InMemorySorters in order to explicitly dispse them when the sort merger is closed. This prevents that InMemorySorters leak and block the garbage collection of MemorySegments to which they keep references. cc @StephanEwen ## Brief change log - Introduce `InMemorySorterFactory` to make `UnilateralSortMerger` testable - Keep reference to created `InMemorySorters` in `UnilateralSortMerger` - Dispose all `InMemorySorters` before releasing memory to `MemoryManager` ## Verifying this change - Added `UnilateralSortMergerTest#testInMemorySorterDisposal` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (no) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no) - The serializers: (no) - The runtime per-record code paths (performance sensitive): (no) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no) - The S3 file system connector: (no) ## Documentation - Does this pull request introduce a new feature? (no) - If yes, how is the feature documented? (not applicable)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
