[
https://issues.apache.org/jira/browse/FLINK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567666#comment-16567666
]
Rong Rong edited comment on FLINK-5315 at 8/3/18 1:25 AM:
----------------------------------------------------------
[~hequn8128], [~fhueske] I am actually close to finish the implementation and
found out that it might be better to use
{code:scala}
myudagg('a, 'b).distinct
{code}
instead of
{code:scala}
myudagg.distinct('a, 'b)
{code}
Since similar modifier is added at the end of the table distinct:
{code:scala}
table.select('a, 'b).distinct
{code}
It might be great to make the modifier location consistent. What do you guys
think?
was (Author: walterddr):
[~hequn8128], [~fhueske] I am actually close to finish the implementation and
found out that it might be better to use
{code:scala}
myudagg('a, 'b).distinct
{code}
instead of
{code:scala}
myudagg.distinct('a, 'b)
{code}
Since similar modifier is added at the end of the table distinct:
`table.select('a, 'b).distinct`. It might be great to make the modifier
location consistent. What do you guys think?
> Support distinct aggregations in table api
> ------------------------------------------
>
> Key: FLINK-5315
> URL: https://issues.apache.org/jira/browse/FLINK-5315
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Kurt Young
> Assignee: Rong Rong
> Priority: Major
>
> Support distinct aggregations in Table API in the following format:
> For Expressions:
> {code:scala}
> 'a.count.distinct // Expressions distinct modifier
> {code}
> For User-defined Function:
> {code:scala}
> singleArgUdaggFunc.distinct('a) // FunctionCall distinct modifier
> multiArgUdaggFunc.distinct('a, 'b) // FunctionCall distinct modifier
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
