medcv commented on issue #6259: [FLINK-9679] Implement AvroSerializationSchema URL: https://github.com/apache/flink/pull/6259#issuecomment-410286209 @tillrohrmann I would appreciate if you take a look also. In last commit all the concerns has been address regarding using `SchemaCoder`. Only remaining concern is passing `subject` to the `ConfluentRegistryAvroSerializationSchema` which related to how Confluent Schema Registry works. As this is only specific to `ConfluentRegistryAvroSerializationSchema` I believe it should be ok to pass `subject` to the ctor.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
