[
https://issues.apache.org/jira/browse/FLINK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568433#comment-16568433
]
ASF GitHub Bot commented on FLINK-10051:
----------------------------------------
zentol opened a new pull request #6486: [FLINK-10051][tests][sql] Add missing
depenendeices for sql client E2E test
URL: https://github.com/apache/flink/pull/6486
## What is the purpose of the change
This PR adds missing dependencies to the sql-client end-to-end test.
The sql-client end-to-end test uses the dependency-plugin to copy a few jars
into the /target directory. However since the module doesn't define
dependencies on these jars there's no guarantee that these jars are built
before the test, or even at all. This caused the tests to fail, since the kafka
0.11 connector wasn't at all and also wasn't available in the SNAPSHOT
repository.
## Brief change log
add dependencies for all kafka connectors, avro and json.
## Verifying this change
flink-ci build: https://travis-ci.org/zentol/flink-ci/builds/411803521
I modified the flink version to guard against the issue being obfuscated by
existing SNAPSHOT artifacts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> SQL client E2E test is missing dependencies
> -------------------------------------------
>
> Key: FLINK-10051
> URL: https://issues.apache.org/jira/browse/FLINK-10051
> Project: Flink
> Issue Type: Bug
> Components: Build System, Table API & SQL, Tests
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> https://travis-ci.org/zentol/flink-ci/builds/411668376
> The sql-client end-to-end test uses the dependency-plugin to copy a few jars
> into the /target directory. However since the module doesn't define
> dependencies on these jars there's no guarantee that these jars are built
> before the test, or even at all. This caused the tests to fail, since the
> kafka 0.11 connector wasn't at all and also wasn't available in the SNAPSHOT
> repository.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
