walterddr commented on a change in pull request #6301: [FLINK-9794] [jdbc]
JDBCOutputFormat does not consider idle connection and multithreads
synchronization
URL: https://github.com/apache/flink/pull/6301#discussion_r207658085
##########
File path:
flink-connectors/flink-jdbc/src/main/java/org/apache/flink/api/java/io/jdbc/JDBCOutputFormat.java
##########
@@ -91,6 +101,19 @@ private void establishConnection() throws SQLException,
ClassNotFoundException {
} else {
dbConn = DriverManager.getConnection(dbURL, username,
password);
}
+ timer = new Timer();
+ timer.schedule(new TimerTask() {
+ @Override
+ public void run() {
+ try {
Review comment:
Should we throw a runtime exceptions here? It might be a better idea to wait
until the actual JDBC write to throw in case it is just transient, and might
got recovered afterwards during batch write
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
