yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add
regex_extract supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6448#discussion_r207699091
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
##########
@@ -450,6 +450,40 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"1111111111111111111111111111111111111111111111111111111111111111")
}
+ @Test
+ def testRegexExtract(): Unit = {
Review comment:
Good point, here is a problem, I wrote this case to test :
```scala
testAllApis(
"foothebar".regexExtract("foo([\\w]+)", 1), //OK, the
method got 'foo([\w]+)'
"'foothebar'.regexExtract('foo([\\\\w]+)', 1)", //failed, the
method got 'foo([\\w]+)' returns "", but if pass 'foo([\\w]+)' would get
compile error.
"REGEX_EXTRACT('foothebar', 'foo([\\\\w]+)', 1)", //OK, the method
got 'foo([\w]+)' but must pass four '\'
"thebar"
)
```
It seems flink pre-process the regex which contains `\xxx`. A few days ago,
we also met this issue when test `similar to` to match the regex which contains
`\d`.
cc @twalthr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
