TisonKun commented on a change in pull request #6491: [FLINK-10057] Update 
FlinkYarnSessionCli.java
URL: https://github.com/apache/flink/pull/6491#discussion_r207723189
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
 ##########
 @@ -530,6 +530,11 @@ protected Configuration 
applyCommandLineOptionsToConfiguration(CommandLine comma
        private boolean isYarnPropertiesFileMode(CommandLine commandLine) {
                boolean canApplyYarnProperties = 
!commandLine.hasOption(addressOption.getOpt());
 
+               //if canApplyYarnProperties is false,return quickly !
+               if (!canApplyYarnProperties){
 
 Review comment:
   code style
   ```java
   // if canApplyYarnProperties is false, return quickly.
   if (!canApplyYarnProperties) {
       return canApplyYarnProperties;
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to