[
https://issues.apache.org/jira/browse/FLINK-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16569660#comment-16569660
]
ASF GitHub Bot commented on FLINK-10020:
----------------------------------------
tweise commented on a change in pull request #6482: [FLINK-10020] [kinesis]
Support recoverable exceptions in listShards.
URL: https://github.com/apache/flink/pull/6482#discussion_r207760823
##########
File path:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxy.java
##########
@@ -409,7 +416,7 @@ private ListShardsResult listShards(String streamName,
@Nullable String startSha
int attemptCount = 0;
// List Shards returns just the first 1000 shard entries. Make
sure that all entries
// are taken up.
- while (listShardsResults == null) { // retry until we get a
result
+ while (attemptCount <= listShardsMaxAttempts &&
listShardsResults == null) { // retry until we get a result
Review comment:
I too think that this is better since it provides the user more flexibility.
Setting the retry count to max practically achieves the previous behavior.
Perhaps we should up the default retry count?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Kinesis Consumer listShards should support more recoverable exceptions
> ----------------------------------------------------------------------
>
> Key: FLINK-10020
> URL: https://issues.apache.org/jira/browse/FLINK-10020
> Project: Flink
> Issue Type: Improvement
> Components: Kinesis Connector
> Reporter: Thomas Weise
> Assignee: Thomas Weise
> Priority: Major
> Labels: pull-request-available
>
> Currently transient errors in listShards make the consumer fail and cause the
> entire job to reset. That is unnecessary for certain exceptions (like status
> 503 errors). It should be possible to control the exceptions that qualify for
> retry, similar to getRecords/isRecoverableSdkClientException.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
