[ 
https://issues.apache.org/jira/browse/FLINK-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571402#comment-16571402
 ] 

ASF GitHub Bot commented on FLINK-9679:
---------------------------------------

dawidwys commented on a change in pull request #6259: [FLINK-9679] Implement 
AvroSerializationSchema
URL: https://github.com/apache/flink/pull/6259#discussion_r208169106
 
 

 ##########
 File path: 
flink-formats/flink-avro-confluent-registry/src/main/java/org/apache/flink/formats/avro/registry/confluent/ConfluentSchemaRegistryCoder.java
 ##########
 @@ -64,4 +81,19 @@ public Schema readSchema(InputStream in) throws IOException 
{
                }
        }
 
+       @Override
+       public byte[] writeSchema(Class tClass, ByteArrayOutputStream out) 
throws IOException {
 
 Review comment:
   The return value is unnecessary. Return `void` from this function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Implement AvroSerializationSchema
> ---------------------------------
>
>                 Key: FLINK-9679
>                 URL: https://issues.apache.org/jira/browse/FLINK-9679
>             Project: Flink
>          Issue Type: Improvement
>    Affects Versions: 1.6.0
>            Reporter: Yazdan Shirvany
>            Assignee: Yazdan Shirvany
>            Priority: Major
>              Labels: pull-request-available
>
> Implement AvroSerializationSchema using Confluent Schema Registry



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to