[
https://issues.apache.org/jira/browse/FLINK-2423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14658237#comment-14658237
]
ASF GitHub Bot commented on FLINK-2423:
---------------------------------------
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/980#issuecomment-128001829
In general I think it has a little more complexity than necessary coming
from the actual application implemented here. I would get rid of the
PrefixCounts and the specific operators for this counting application and would
replace them with simple filters and maps.
I think that would serve the same purpose and would not hide the actual
notification tests with a lot of unnecessary details
> Properly test checkpoint notifications
> --------------------------------------
>
> Key: FLINK-2423
> URL: https://issues.apache.org/jira/browse/FLINK-2423
> Project: Flink
> Issue Type: Improvement
> Components: Streaming
> Reporter: Gyula Fora
> Assignee: Márton Balassi
>
> Checkpoint notifications (via the CheckpointNotifier interface) are currently
> not properly tested.
> A test should be included to verify that checkpoint notifications are
> eventually called on successful checkpoints, and that they are only called
> once per checkpointID.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
