[
https://issues.apache.org/jira/browse/FLINK-10094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571665#comment-16571665
]
ASF GitHub Bot commented on FLINK-10094:
----------------------------------------
florianschmidt1994 commented on a change in pull request #6518:
[FLINK-10094][tests] Always backup config before running test
URL: https://github.com/apache/flink/pull/6518#discussion_r208233155
##########
File path: flink-end-to-end-tests/test-scripts/test-runner-common.sh
##########
@@ -64,9 +64,7 @@ function run_test {
fi
fi
- if [[ ${exit_code} == 0 ]]; then
- cleanup
- else
+ if [[ ${exit_code} != 0 ]]; then
Review comment:
if there is only `exit "${exit_code}"` in there I think we can completely
drop it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Always backup default config for end-to-end tests
> -------------------------------------------------
>
> Key: FLINK-10094
> URL: https://issues.apache.org/jira/browse/FLINK-10094
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.6.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0
>
>
> end-to-end tests frequently modify the configuration before running a test;
> to set state backends, # of task slots, reporters, etc.
> Currently it is the responsibility of the test to create a backup of the
> config before doing any modifications, which is then restored by the runner
> after the test.
> Instead we can have the test runner always create a backup before running the
> test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
