[ 
https://issues.apache.org/jira/browse/FLINK-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16571705#comment-16571705
 ] 

ASF GitHub Bot commented on FLINK-9859:
---------------------------------------

tillrohrmann commented on a change in pull request #6339: [FLINK-9859] 
[runtime] distinguish JM akka config
URL: https://github.com/apache/flink/pull/6339#discussion_r208239960
 
 

 ##########
 File path: 
flink-mesos/src/main/java/org/apache/flink/mesos/runtime/clusterframework/MesosApplicationMasterRunner.java
 ##########
 @@ -239,6 +240,15 @@ protected int runPrivileged(Configuration config, 
Configuration dynamicPropertie
 
                        // ----------------- (2) start the actor system 
-------------------
 
+                       // Enlarge thread pool to improve the performance of 
ActorSystem.
+                       
config.setDouble(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_FACTOR, 1.0);
+                       
config.setInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MIN, 16);
+                       
config.setInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MAX, 64);
+                       
config.setInteger(AkkaOptions.SERVER_SOCKET_WORKER_POOL_SIZE_MIN, 8);
+                       
config.setInteger(AkkaOptions.SERVER_SOCKET_WORKER_POOL_SIZE_MAX, 64);
+                       
config.setInteger(AkkaOptions.CLIENT_SOCKET_WORKER_POOL_SIZE_MIN, 8);
+                       
config.setInteger(AkkaOptions.CLIENT_SOCKET_WORKER_POOL_SIZE_MIN, 64);
 
 Review comment:
   I think we should not overwrite the configuration settings here. The user 
should specify them in his `flink-conf.yaml`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Distinguish TM akka config with JM config
> -----------------------------------------
>
>                 Key: FLINK-9859
>                 URL: https://issues.apache.org/jira/browse/FLINK-9859
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 1.5.1
>            Reporter: 陈梓立
>            Assignee: 陈梓立
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.5.3
>
>
> ... increase the number of akka threads on JM, to improve its performance; 
> decrease the number of akka threads on TM, to save resource.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to