dawidwys commented on a change in pull request #6294: [FLINK-9013][docs]
Document yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208969123
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
##########
@@ -34,9 +36,22 @@ protected void formatLineBreak(StringBuilder state) {
}
@Override
- protected void formatText(StringBuilder state, String format, String[]
elements) {
+ protected void formatText(
+ StringBuilder state,
+ String format,
+ String[] elements,
+ EnumSet<TextElement.TextStyle> styles) {
String escapedFormat = escapeCharacters(format);
+
+ StringBuilder prefix = new StringBuilder();
+ StringBuilder sufix = new StringBuilder();
+ if (styles.contains(TextElement.TextStyle.CODE)) {
+ prefix.append("<tt>");
+ sufix.append("</tt>");
+ }
Review comment:
That would make sense if we had more TextStyles, but as we don't have them
I've changed it to your code snippet.
Also fixed the typo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
