[
https://issues.apache.org/jira/browse/FLINK-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575055#comment-16575055
]
ASF GitHub Bot commented on FLINK-9013:
---------------------------------------
GJL commented on a change in pull request #6294: [FLINK-9013][docs] Document
yarn.containers.vcores only being effective whe…
URL: https://github.com/apache/flink/pull/6294#discussion_r208986466
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/description/HtmlFormatter.java
##########
@@ -34,9 +36,22 @@ protected void formatLineBreak(StringBuilder state) {
}
@Override
- protected void formatText(StringBuilder state, String format, String[]
elements) {
+ protected void formatText(
+ StringBuilder state,
+ String format,
+ String[] elements,
+ EnumSet<TextElement.TextStyle> styles) {
String escapedFormat = escapeCharacters(format);
+
+ String prefix = "";
+ String suffix = "";
+ if (styles.contains(TextElement.TextStyle.CODE)) {
+ prefix = "<tt>";
Review comment:
What I don't like is that `<tt>` or `<code>` might not get formatted the
same way as markdown's backticks. Why don't we enable markdown syntax in HTML
tags. There is a configuration option in Kramdown, the default HTML converter
in Jekyll:
> By default, kramdown parses all block HTML tags and all XML tags as raw
HTML blocks. However, this can be configured with the parse_block_html. If this
is set to true, then syntax parsing in HTML blocks is globally enabled. It is
also possible to enable/disable syntax parsing on a tag per tag basis using the
markdown attribute:
>
> If an HTML tag has an attribute markdown="0", then the tag is parsed as
raw HTML block.
>
> If an HTML tag has an attribute markdown="1", then the default
mechanism for parsing syntax in this tag is used.
>
> If an HTML tag has an attribute markdown="block", then the content of
the tag is parsed as block level elements.
>
> If an HTML tag has an attribute markdown="span", then the content of
the tag is parsed as span level elements.
https://kramdown.gettalong.org/syntax.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Document yarn.containers.vcores only being effective when adapting YARN config
> ------------------------------------------------------------------------------
>
> Key: FLINK-9013
> URL: https://issues.apache.org/jira/browse/FLINK-9013
> Project: Flink
> Issue Type: Improvement
> Components: Documentation, YARN
> Affects Versions: 1.5.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.3
>
>
> Even after specifying {{yarn.containers.vcores}} and having Flink request
> such a container from YARN, it may not take these into account at all and
> return a container with 1 vcore.
> The YARN configuration needs to be adapted to take the vcores into account,
> e.g. by setting the {{FairScheduler}} in {{yarn-site.xml}}:
> {code}
> <property>
> <name>yarn.resourcemanager.scheduler.class</name>
>
> <value>org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler</value>
> </property>
> {code}
> This fact should be documented at least at the configuration parameter
> documentation of {{yarn.containers.vcores}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
