[ 
https://issues.apache.org/jira/browse/FLINK-10107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16575881#comment-16575881
 ] 

ASF GitHub Bot commented on FLINK-10107:
----------------------------------------

twalthr commented on issue #6534: [FLINK-10107] [sql-client] Relocate Flink 
Kafka connectors for SQL JARs
URL: https://github.com/apache/flink/pull/6534#issuecomment-412001055
 
 
   @zentol The goal of SQL jars was to provide ready-to-use libraries that 
could be added on a drag and drop basis. We do not need to support multiple 
Kafka versions. Even though I can image ETL cases where you might want to read 
from a global Kafka storage (maybe using an old version) to a testing storage 
(maybe using a newer version).
   
   This PR tries to solve the problem of having SQL jars that interfere with 
each other. The root cause of this is actually our current dependency structure 
for Kafka connectors. We have a Kafka-base but actually depend on the previous 
versions. After sleeping a night over this PR, I think we cannot merge this 
because we expose FlinkKafkaPartitioner which is also relocated now.
   
   A perfect solution would be:
   - Move version-specific Kafka code into version-specific packages (e.g. 
o.a.f.kafka10)
   - Move version-agnostic Kafka code into a common package (e.g. o.a.f.kafka)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SQL Client end-to-end test fails for releases
> ---------------------------------------------
>
>                 Key: FLINK-10107
>                 URL: https://issues.apache.org/jira/browse/FLINK-10107
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Timo Walther
>            Priority: Major
>              Labels: pull-request-available
>
> It seems that SQL JARs for Kafka 0.10 and Kafka 0.9 have conflicts that only 
> occur for releases and not SNAPSHOT builds. This might be due to their file 
> name. Depending on the file name either 0.9 is loaded before 0.10 and vice 
> versa.
> One of the following errors occured:
> {code}
> 2018-08-08 18:28:51,636 ERROR 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.ClientUtils  - 
> Failed to close coordinator
> java.lang.NoClassDefFoundError: 
> org/apache/flink/kafka09/shaded/org/apache/kafka/common/requests/OffsetCommitResponse
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.sendOffsetCommitRequest(ConsumerCoordinator.java:473)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.commitOffsetsSync(ConsumerCoordinator.java:357)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.maybeAutoCommitOffsetsSync(ConsumerCoordinator.java:439)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.close(ConsumerCoordinator.java:319)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.ClientUtils.closeQuietly(ClientUtils.java:63)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.KafkaConsumer.close(KafkaConsumer.java:1277)
>     at 
> org.apache.flink.kafka09.shaded.org.apache.kafka.clients.consumer.KafkaConsumer.close(KafkaConsumer.java:1258)
>     at 
> org.apache.flink.streaming.connectors.kafka.internal.KafkaConsumerThread.run(KafkaConsumerThread.java:286)
> Caused by: java.lang.ClassNotFoundException: 
> org.apache.flink.kafka09.shaded.org.apache.kafka.common.requests.OffsetCommitResponse
>     at java.net.URLClassLoader.findClass(URLClassLoader.java:381)
>     at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
>     at 
> org.apache.flink.runtime.execution.librarycache.FlinkUserCodeClassLoaders$ChildFirstClassLoader.loadClass(FlinkUserCodeClassLoaders.java:120)
>     at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
>     ... 8 more
> {code}
> {code}
> java.lang.NoSuchFieldError: producer
>     at 
> org.apache.flink.streaming.connectors.kafka.FlinkKafkaProducer010.invoke(FlinkKafkaProducer010.java:369)
>     at 
> org.apache.flink.streaming.api.operators.StreamSink.processElement(StreamSink.java:56)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:579)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:554)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:534)
>     at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:689)
>     at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:667)
>     at 
> org.apache.flink.streaming.api.operators.StreamMap.processElement(StreamMap.java:41)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.pushToOperator(OperatorChain.java:579)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:554)
>     at 
> org.apache.flink.streaming.runtime.tasks.OperatorChain$CopyingChainingOutput.collect(OperatorChain.java:534)
>     at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:689)
>     at 
> org.apache.flink.streaming.api.operators.AbstractStreamOperator$CountingOutput.collect(AbstractStreamOperator.java:667)
>     at 
> org.apache.flink.streaming.api.operators.TimestampedCollector.collect(TimestampedCollector.java:51)
>     at 
> org.apache.flink.table.runtime.CRowWrappingCollector.collect(CRowWrappingCollector.scala:37)
>     at 
> org.apache.flink.table.runtime.CRowWrappingCollector.collect(CRowWrappingCollector.scala:28)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to