dawidwys commented on a change in pull request #6205: [FLINK-9642]Reduce the 
count to deal with state during a CEP process
URL: https://github.com/apache/flink/pull/6205#discussion_r209249647
 
 

 ##########
 File path: 
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/sharedbuffer/SharedBuffer.java
 ##########
 @@ -25,58 +25,37 @@
 import org.apache.flink.api.common.typeutils.TypeSerializer;
 import org.apache.flink.api.common.typeutils.base.IntSerializer;
 import org.apache.flink.api.common.typeutils.base.LongSerializer;
-import org.apache.flink.api.java.tuple.Tuple2;
-import org.apache.flink.cep.nfa.DeweyNumber;
-import org.apache.flink.util.WrappingRuntimeException;
 
 import org.apache.flink.shaded.guava18.com.google.common.collect.Iterables;
 
-import org.apache.commons.lang3.StringUtils;
-
-import javax.annotation.Nullable;
-
-import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.Iterator;
-import java.util.LinkedHashMap;
-import java.util.List;
 import java.util.Map;
-import java.util.Stack;
 import java.util.stream.Collectors;
 
-import static 
org.apache.flink.cep.nfa.compiler.NFAStateNameHandler.getOriginalNameFromInternal;
-import static org.apache.flink.util.Preconditions.checkState;
-
 /**
- * A shared buffer implementation which stores values under according state. 
Additionally, the values can be
- * versioned such that it is possible to retrieve their predecessor element in 
the buffer.
- *
- * <p>The idea of the implementation is to have a buffer for incoming events 
with unique ids assigned to them. This way
- * we do not need to deserialize events during processing and we store only 
one copy of the event.
- *
- * <p>The entries in {@link SharedBuffer} are {@link SharedBufferNode}. The 
shared buffer node allows to store
- * relations between different entries. A dewey versioning scheme allows to 
discriminate between
- * different relations (e.g. preceding element).
- *
- * <p>The implementation is strongly based on the paper "Efficient Pattern 
Matching over Event Streams".
- *
- * @param <V> Type of the values
- * @see <a 
href="https://people.cs.umass.edu/~yanlei/publications/sase-sigmod08.pdf";>
- * https://people.cs.umass.edu/~yanlei/publications/sase-sigmod08.pdf</a>
+ * This is a helper class of {@link SharedBufferAccessor}. It do the cache of 
the underlay sharedBuffer state
+ * during a nfa process. It can reduce the state access when the ref change is 
requested several times on
+ * a same {@code Lockable} Object. And it also implements the {@code 
AutoCloseable} interface to flush the
 
 Review comment:
   Outdated javadoc. It is no longer Autoclosable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to