pnowojski commented on a change in pull request #6367: [FLINK-9850] Add a 
string to the print method to identify output for DataStream
URL: https://github.com/apache/flink/pull/6367#discussion_r209239178
 
 

 ##########
 File path: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/functions/PrintSinkFunctionTest.java
 ##########
 @@ -117,6 +117,65 @@ public void testPrintSinkWithPrefix() throws Exception {
                stream.close();
        }
 
+       @Test
+       public void testPrintSinkWithIdentifierAndPrefix() throws Exception {
+               ByteArrayOutputStream baos = new ByteArrayOutputStream();
+               PrintStream stream = new PrintStream(baos);
+               System.setOut(stream);
+
+               final StreamingRuntimeContext ctx = 
Mockito.mock(StreamingRuntimeContext.class);
 
 Review comment:
   Do not use mockito for such things, it's very difficult to maintain such 
tests in the future. Instead please move 
`org.apache.flink.streaming.connectors.kafka.FlinkKafkaConsumerBaseTest.MockRuntimeContext`
 class to `flink-streaming-java` module to some utility package and reuse it in 
this whole `PrintSinkFunctionTest`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to