yanghua commented on a change in pull request #6540: [FLINK-9891] Added hook to 
shutdown cluster if a session was created in per-job mode.
URL: https://github.com/apache/flink/pull/6540#discussion_r209443343
 
 

 ##########
 File path: 
flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
 ##########
 @@ -1219,4 +1231,21 @@ public static void 
setJobManagerAddressInConfig(Configuration config, InetSocket
                return constructor.newInstance(params);
        }
 
+       private static class ClusterShutdownHook extends Thread {
+               private final ClusterClient<?> client;
+
+               ClusterShutdownHook(ClusterClient<?> client) {
 
 Review comment:
   here use `@Nonnull` looks better to me

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to