twalthr commented on a change in pull request #6337: [FLINK-9853] [table] Add
HEX support
URL: https://github.com/apache/flink/pull/6337#discussion_r209582133
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/mathExpressions.scala
##########
@@ -422,3 +422,21 @@ case class Bin(child: Expression) extends UnaryExpression
{
relBuilder.call(ScalarSqlFunctions.BIN, child.toRexNode)
}
}
+
+case class Hex(child: Expression) extends UnaryExpression {
+ override private[flink] def resultType: TypeInformation[_] =
BasicTypeInfo.STRING_TYPE_INFO
+
+ override private[flink] def validateInput(): ValidationResult =
child.resultType match {
+ case _: IntegerTypeInfo[_] =>
Review comment:
Rely on `TypeCheckUtils.isIntegerFamily` and `TypeCheckUtils#isString`
instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
