twalthr commented on a change in pull request #6359: [FLINK-6895][table]Add STR_TO_DATE supported in SQL URL: https://github.com/apache/flink/pull/6359#discussion_r209881790
########## File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/StrToDateCallGen.scala ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.codegen.calls + +import org.apache.flink.api.common.typeinfo.SqlTimeTypeInfo +import org.apache.flink.table.codegen.calls.CallGenerator.generateCallIfArgsNotNull +import org.apache.flink.table.codegen.{CodeGenerator, GeneratedExpression} +import org.apache.flink.table.runtime.functions.DateTimeFunctions + +/** + * Generates StrToDate call based on the type of last operand. + */ +class StrToDateCallGen extends CallGenerator { + override def generate(codeGenerator: CodeGenerator, + operands: Seq[GeneratedExpression]): GeneratedExpression = { + if (operands.last.literal) { Review comment: In the CodeGenerator line 744 you can see that we calculate the result type from Calcite: ``` val resultType = FlinkTypeFactory.toTypeInfo(call.getType) ``` We cannot simply return our own type for functions, we always need to stay in sync with Calcite. For following operators such as: ``` 1. DataStreamCalc(field: DATE) # if we would return TIMESTAMP here, the following operation would still assume DATE, thus we get a type mismatch. 2. DataStreamCalc((field + 1): DATE) ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
