[
https://issues.apache.org/jira/browse/FLINK-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579856#comment-16579856
]
ASF GitHub Bot commented on FLINK-10022:
----------------------------------------
zentol commented on a change in pull request #6551:
[FLINK-10022][network][metrics] add metrics for input/output buffers
URL: https://github.com/apache/flink/pull/6551#discussion_r209965189
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/IOMetrics.java
##########
@@ -48,6 +48,7 @@ public IOMetrics(Meter recordsIn, Meter recordsOut, Meter
bytesLocalIn, Meter by
this.numRecordsInPerSecond = recordsIn.getRate();
this.numRecordsOut = recordsOut.getCount();
this.numRecordsOutPerSecond = recordsOut.getRate();
+
Review comment:
revert
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add metrics for input/output buffers
> ------------------------------------
>
> Key: FLINK-10022
> URL: https://issues.apache.org/jira/browse/FLINK-10022
> Project: Flink
> Issue Type: Improvement
> Components: Metrics, Network
> Affects Versions: 1.5.2, 1.6.0, 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
>
> Currently, we provide metrics for the input and output queue lengths, records
> and bytes. For diagnosing network issues, it would also be nice to know the
> number of buffers because we would then know their fill rate.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
