[ 
https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579899#comment-16579899
 ] 

Hequn Cheng edited comment on FLINK-8545 at 8/14/18 3:20 PM:
-------------------------------------------------------------

[~pnowojski]
Great to have your response. The {{UpsertStreamTable}} and 
{{AppendStreamTable}} are internal classes which are used during 
{{registerTableInternal}}. 

Flag is a good choice, but it is difficult to handle the DataStream type. When 
upsert from stream, the input type is always tuple type(see FLINK-8577). To 
solve the type problem, I create the {{UpsertStreamTable}} to ingest datastream 
with type of tuple2. 

Considering {{UpsertToRetractOperator}}, I think it should be an {{UpsertNode}} 
and it may be translated into an {{UpsertWithRetractNode}} by the current 
RetractionRules. 

Thanks again for your suggestions. I have posted a simple design doc just now 
in [FLINK-8577|https://issues.apache.org/jira/browse/FLINK-8577]. 


was (Author: hequn8128):
[~pnowojski]
Great to have your response. The {{UpsertStreamTable}} and 
{{AppendStreamTable}} are internal classes which are used during 
{{registerTableInternal}}. 

Flag is a good choice, but it is difficult to handle the DataStream type. When 
upsert from stream, the input type is always tuple type(see FLINK-8577). To 
solve the type problem, I create the {{UpsertStreamTable}} to ingest datastream 
with type of tuple2. 

Considering {{UpsertToRetractOperator}}, I think it should be an {{UpsertNode}} 
and it may be translated into an {{UpsertWithRetractNode}} by the current 
RetractionRules. 

Thanks again for your suggestions. I will post a design doc ASAP. 

> Implement upsert stream table source 
> -------------------------------------
>
>                 Key: FLINK-8545
>                 URL: https://issues.apache.org/jira/browse/FLINK-8545
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API & SQL
>            Reporter: Hequn Cheng
>            Assignee: Hequn Cheng
>            Priority: Major
>
> As more and more users are eager for ingesting data with upsert mode in flink 
> sql/table-api, it is valuable to enable table source with upsert mode. I will 
> provide a design doc later and we can have more discussions. Any suggestions 
> are warmly welcomed !
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to