GJL commented on a change in pull request #6550: [FLINK-10137][YARN] Log 
completed containers.
URL: https://github.com/apache/flink/pull/6550#discussion_r210040202
 
 

 ##########
 File path: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java
 ##########
 @@ -323,9 +323,10 @@ public float getProgress() {
        }
 
        @Override
-       public void onContainersCompleted(final List<ContainerStatus> list) {
+       public void onContainersCompleted(final List<ContainerStatus> statuses) 
{
                runAsync(() -> {
-                               for (final ContainerStatus containerStatus : 
list) {
+                               log.debug("YARN ResourceManager reported the 
following containers completed: {}.", statuses);
 
 Review comment:
   That depends on the `List` implementation. At least 
`java.util.AbstractCollection` has a meaningful string representation. The List 
returned by Hadoop 2.8 as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to