Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/983#issuecomment-128396895
Two comments on the singleton change:
- The Tuple0.class.newInstance() will now probably fail (due to the
private constructor)
- Java serialization still creates copies. Need to overwrite the
`readResolve()` method to create proper singletons.
- It is probably okay allow Tuple0 instances to be created. We could
simply providing a static shareable instance in the class for convenience
(soft-singleton style).
@twalthr Are the TypeExctractor related changes good?
Thanks for reverting the whitespace changes. I did actually not expect
that, it was more a comment for future pull requests...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
