[ 
https://issues.apache.org/jira/browse/FLINK-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14660126#comment-14660126
 ] 

ASF GitHub Bot commented on FLINK-2492:
---------------------------------------

GitHub user StephanEwen opened a pull request:

    https://github.com/apache/flink/pull/995

    [FLINK-2492] [runtime] Rename former 'match' classes to 'join' to reflect 
consistent naming scheme

    The renamed classes are
      - `MatchDriver.java` → `JoinDriver.java`
      - `AbstractCachedBuildSideMatchDriver.java` → 
`AbstractCachedBuildSideJoinDriver.java`
      - `BuildFirstCachedMatchDriver.java` → `BuildFirstCachedJoinDriver.java`
      - `BuildSecondCachedMatchDriver.java` → `BuildSecondCachedJoinDriver.java`
    
    Also corrects comments in the `JoinDriver` class.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/StephanEwen/incubator-flink match_join_rename

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/995.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #995
    
----
commit da74896200392b0cbc12aa744151d9cd3943f773
Author: Stephan Ewen <[email protected]>
Date:   2015-08-06T13:18:14Z

    [FLINK-2492] [runtime] Rename former 'match' classes to 'join' to reflect 
consistent naming scheme.

----


> Rename remaining runtime classes from "match" to "join"
> -------------------------------------------------------
>
>                 Key: FLINK-2492
>                 URL: https://issues.apache.org/jira/browse/FLINK-2492
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>    Affects Versions: 0.10
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Minor
>             Fix For: 0.10
>
>
> While working with the runtime join classes, I saw that many of them still 
> refer to the "join" as "match".
> Since all other parts now consistently refer to "join", we should adjust the 
> runtime classes as well. Makes it easier for new contributors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to