[
https://issues.apache.org/jira/browse/FLINK-10151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16581377#comment-16581377
]
ASF GitHub Bot commented on FLINK-10151:
----------------------------------------
azagrebin opened a new pull request #6563: [FLINK-10151] [State TTL] Fix false
recursion call in TransformingStateTableKeyGroupPartitioner.tryAddToSource
URL: https://github.com/apache/flink/pull/6563
## What is the purpose of the change
This PR fixes bug in
`TransformingStateTableKeyGroupPartitioner.tryAddToSource` which calls itself
instead of its super method.
## Brief change log
- call `super.tryAddToSource` in
`TransformingStateTableKeyGroupPartitioner.tryAddToSource`
- extend TTL test suite with asynchronous snapshot mode for heap backend
## Verifying this change
State TTL unit tests
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [State TTL] Fix false recursion call in
> TransformingStateTableKeyGroupPartitioner.tryAddToSource
> ------------------------------------------------------------------------------------------------
>
> Key: FLINK-10151
> URL: https://issues.apache.org/jira/browse/FLINK-10151
> Project: Flink
> Issue Type: Bug
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: Andrey Zagrebin
> Assignee: Andrey Zagrebin
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.1, 1.7.0
>
>
> *TransformingStateTableKeyGroupPartitioner* currently calls *tryAddToSource*
> recursively but has to call the super method of extended
> *StateTableKeyGroupPartitioner*. It can lead to infinite recursion when full
> snapshot cleanup strategy is activated for heap backend in async snapshot
> mode. The *HeapTtlStateTest* should be also divided into sync and async mode
> test suites to catch the problem.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
