[
https://issues.apache.org/jira/browse/FLINK-10149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16582687#comment-16582687
]
ASF GitHub Bot commented on FLINK-10149:
----------------------------------------
yanghua commented on a change in pull request #6557: [FLINK-10149]
[flink-mesos] Don't allocate extra mesos port for TM unless configured to do so.
URL: https://github.com/apache/flink/pull/6557#discussion_r210638112
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/configuration/MesosOptions.java
##########
@@ -137,7 +137,7 @@
* Config parameter to configure which configuration keys will
dynamically get a port assigned through Mesos.
*/
public static final ConfigOption<String> PORT_ASSIGNMENTS =
key("mesos.resourcemanager.tasks.port-assignments")
Review comment:
change :
```java
public static final ConfigOption<String> PORT_ASSIGNMENTS =
key("mesos.resourcemanager.tasks.port-assignments")
```
to :
```java
public static final ConfigOption<String> PORT_ASSIGNMENTS =
key("mesos.resourcemanager.tasks.port-assignments")
```
let it match other configuration item's style, looks better to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fink Mesos allocates extra port when not configured to do so.
> -------------------------------------------------------------
>
> Key: FLINK-10149
> URL: https://issues.apache.org/jira/browse/FLINK-10149
> Project: Flink
> Issue Type: Bug
> Reporter: Rune Skou Larsen
> Assignee: Rune Skou Larsen
> Priority: Minor
> Labels: pull-request-available
>
> Internal testing has revealed a small bug in the way LaunchableMesosWorker
> handles the absense of the new *mesos.resourcemanager.tasks.port-assignments*
> config option.
> It allocates an extra mesos port even when the option is not set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
