yanghua commented on a change in pull request #6576: [FLINK-10145][table] Add
replace supported in TableAPI and SQL
URL: https://github.com/apache/flink/pull/6576#discussion_r211091929
##########
File path:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/expressions/ScalarFunctionsTest.scala
##########
@@ -94,6 +94,21 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"his is a test String.")
}
+ @Test
+ def testReplace(): Unit = {
Review comment:
add more test for invalid input such : empty string, null or a string is not
available of the original string
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
