NicoK commented on a change in pull request #6581: [FLINK-6670][tests] Remove
CommonTestUtils#createTempDirectory
URL: https://github.com/apache/flink/pull/6581#discussion_r211189707
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureBatchRecoveryITCase.java
##########
@@ -95,33 +94,21 @@
private static final FiniteDuration TestTimeOut = new FiniteDuration(5,
TimeUnit.MINUTES);
- private static final File FileStateBackendBasePath;
-
- static {
- try {
- FileStateBackendBasePath =
CommonTestUtils.createTempDirectory();
- }
- catch (IOException e) {
- throw new RuntimeException("Error in test setup. Could
not create directory.", e);
- }
- }
+ @Rule
+ public final TemporaryFolder temporaryFolder = new TemporaryFolder();
+
+ private File zookeeperStoragePath;
Review comment:
while at it, you could also reduce the visibility of
`testJobManagerFailure()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
