[ 
https://issues.apache.org/jira/browse/FLINK-10127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586574#comment-16586574
 ] 

ASF GitHub Bot commented on FLINK-10127:
----------------------------------------

fhueske commented on a change in pull request #6549: [FLINK-10127] Add Instant 
to basic types
URL: https://github.com/apache/flink/pull/6549#discussion_r211405853
 
 

 ##########
 File path: 
flink-core/src/main/java/org/apache/flink/api/common/typeinfo/Types.java
 ##########
 @@ -150,6 +151,12 @@
         */
        public static final TypeInformation<Timestamp> SQL_TIMESTAMP = 
SqlTimeTypeInfo.TIMESTAMP;
 
+
+       /**
+        * Returns type infomation for {@link java.time.Instant}. Supports a 
null value.
+        */
+       public static final TypeInformation<Instant> INSTANT = 
BasicTypeInfo.INSTANT_TYPE_INFO;
 
 Review comment:
   Add it to `org.apache.flink.api.scala.typeutils.Types` as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add TypeInformation  and serializers for JDK8 Instant
> -----------------------------------------------------
>
>                 Key: FLINK-10127
>                 URL: https://issues.apache.org/jira/browse/FLINK-10127
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Alexey Trenikhin
>            Priority: Minor
>              Labels: pull-request-available
>
> Currently Flink's basic types include all Java primitives and their boxed 
> form, plus {{void}}, {{String}}, {{Date}}, {{BigDecimal}}, and 
> {{BigInteger}}. New JDK8 Instance type should be added as well



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to