dawidwys commented on a change in pull request #6205: [FLINK-9642]Reduce the
count to deal with state during a CEP process
URL: https://github.com/apache/flink/pull/6205#discussion_r211203575
##########
File path:
flink-libraries/flink-cep/src/test/java/org/apache/flink/cep/nfa/NFAStateAccessTest.java
##########
@@ -101,12 +102,14 @@ public boolean filter(Event value) throws Exception {
NFA<Event> nfa = compile(pattern, false);
TestSharedBuffer<Event> sharedBuffer =
TestSharedBuffer.createTestBuffer(Event.createTypeSerializer());
- for (StreamRecord<Event> inputEvent : inputEvents) {
- nfa.process(
- sharedBuffer,
- nfa.createInitialNFAState(),
- inputEvent.getValue(),
- inputEvent.getTimestamp());
+ try (SharedBufferAccessor accessor =
sharedBuffer.getAccessor()) {
Review comment:
Try block should be within the for, as accessor should not be shared across
different events.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
