[ 
https://issues.apache.org/jira/browse/FLINK-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16589439#comment-16589439
 ] 

ASF GitHub Bot commented on FLINK-10172:
----------------------------------------

walterddr edited a comment on issue #6585: [FLINK-10172][table]re-adding asc & 
desc suffix expression to expressionParser
URL: https://github.com/apache/flink/pull/6585#issuecomment-415214473
 
 
   @twalthr I just did a cross-check and all touched expressions are covered in 
testings. :-) The only thing not covered is `"w.start()"` in addition to 
`"start(w)"`. which I think we can leave it as it is not necessary to treat as 
a special expression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc
> --------------------------------------------------------------------------
>
>                 Key: FLINK-10172
>                 URL: https://issues.apache.org/jira/browse/FLINK-10172
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.3.3, 1.4.2, 1.5.3, 1.6.0, 1.7.0
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.3.3, 1.4.3, 1.6.1, 1.7.0, 1.5.4
>
>
> The following expression throws an exception in parsing {{"id.asc"}} term.
> {code:java}
> Table allOrders = orderTable
>         .select("id,order_date,amount,customer_id")
>         .orderBy("id.asc");
> {code}
> while it is correctly parsed for Scala:
> {code:scala}
> val allOrders:Table = orderTable
>         .select('id, 'order_date, 'amount, 'customer_id)
>         .orderBy('id.asc)
> {code}
> Anticipated some inconsistency between ExpressionParser and ExpressionDsl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to