benlamonica commented on a change in pull request #6610: [FLINK-10204] - fix
serialization/copy error for LatencyMarker records.
URL: https://github.com/apache/flink/pull/6610#discussion_r212639070
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/streamrecord/StreamElementSerializerTest.java
##########
@@ -89,6 +90,9 @@ public void testSerialization() throws Exception {
Watermark negativeWatermark = new
Watermark(-4647654567676555876L);
assertEquals(negativeWatermark,
serializeAndDeserialize(negativeWatermark, serializer));
+
+ LatencyMarker latencyMarker = new
LatencyMarker(System.currentTimeMillis(), new OperatorID(-1, -1), 1);
+ assertEquals(latencyMarker,
serializeAndDeserialize(latencyMarker, serializer));
Review comment:
hashCode and equals changes are to support this line here. Without it, even
though the objects have the same values, they still evaluate as not equal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
