zentol commented on a change in pull request #6610: [FLINK-10204] - fix
serialization/copy error for LatencyMarker records.
URL: https://github.com/apache/flink/pull/6610#discussion_r212645193
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/streamrecord/LatencyMarker.java
##########
@@ -67,31 +67,40 @@ public int getSubtaskIndex() {
//
------------------------------------------------------------------------
@Override
- public boolean equals(Object o) {
- if (this == o) {
+ public boolean equals(Object obj) {
+ if (this == obj) {
return true;
}
- if (o == null || getClass() != o.getClass()){
+ if (obj == null) {
return false;
}
-
- LatencyMarker that = (LatencyMarker) o;
-
- if (markedTime != that.markedTime) {
+ if (getClass() != obj.getClass()) {
return false;
}
- if (operatorId != that.operatorId) {
+ LatencyMarker other = (LatencyMarker) obj;
+ if (markedTime != other.markedTime) {
return false;
}
- return subtaskIndex == that.subtaskIndex;
-
+ if (operatorId == null) {
+ if (other.operatorId != null) {
+ return false;
+ }
+ } else if (!operatorId.equals(other.operatorId)) {
+ return false;
+ }
+ if (subtaskIndex != other.subtaskIndex) {
+ return false;
+ }
+ return true;
}
@Override
public int hashCode() {
- int result = (int) (markedTime ^ (markedTime >>> 32));
Review comment:
This change isn't necessary, please revert.
While it is theoretically possible for operatorId to be null, in practices
this won't happen.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
