[ 
https://issues.apache.org/jira/browse/FLINK-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14661598#comment-14661598
 ] 

ASF GitHub Bot commented on FLINK-2451:
---------------------------------------

GitHub user vasia opened a pull request:

    https://github.com/apache/flink/pull/1000

    [FLINK-2451] [gelly] examples and library cleanup

    This PR contains a refactoring and cleanup of the gelly exmaples and 
library methods, as discussed in the mailing list. Tests have been adjusted 
accordingly.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vasia/flink examples-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1000
    
----
commit ce0119a059b3acd0a75c01f53e484664a0dc5541
Author: vasia <[email protected]>
Date:   2015-08-03T12:37:19Z

    [FLINK-2451] [gelly] removed redundant examples; added comments describing 
which gelly method each example illustrates.

commit 721137ede022aafa434f210ccd65ac05c372c68e
Author: vasia <[email protected]>
Date:   2015-08-03T13:20:44Z

    [FLINK-2451] [gelly] library methods cleanup

commit 2a90178b7d629cceb46a0431ef39cb9fd91b7c41
Author: vasia <[email protected]>
Date:   2015-08-07T09:28:20Z

    [FLINK-2451] [gelly] re-organized tests; compare with collect() instead of 
temp files where possible

----


> Cleanup Gelly examples
> ----------------------
>
>                 Key: FLINK-2451
>                 URL: https://issues.apache.org/jira/browse/FLINK-2451
>             Project: Flink
>          Issue Type: Improvement
>          Components: Gelly
>    Affects Versions: 0.10
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>            Priority: Minor
>
> As per discussion in the dev@ mailing list, this issue proposes the following 
> changes to the Gelly examples and library:
> 1. Keep the following examples as they are:
> EuclideanGraphWeighing, GraphMetrics, IncrementalSSSP, JaccardSimilarity,  
> MusicProfiles.
> 2. Keep only 1 example to show how to use library methods.
> 3. Add 1 example for vertex-centric iterations.
> 4. Keep 1 example for GSA iterations and move the redundant GSA 
> implementations to the library.
> 5. Improve the examples documentation and refer to the functionality that 
> each of them demonstrates.
> 6. Port and modify existing example tests accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to