NicoK commented on a change in pull request #6417: [FLINK-9913][runtime]
Improve output serialization only once in RecordWriter
URL: https://github.com/apache/flink/pull/6417#discussion_r212980692
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java
##########
@@ -524,6 +615,31 @@ public void read(DataInputView in) throws IOException {
}
}
+ /**
+ * Broadcast channel selector that selects all the output channels.
+ */
+ private static class Broadcast<T extends IOReadableWritable> implements
ChannelSelector<T> {
+
+ private int[] returnChannel;
+ boolean set;
Review comment:
Actually, this is a copy of
`org.apache.flink.streaming.runtime.partitioner.BroadcastPartitioner` which is
in the `flink-streaming-java` submodule, though.
And in general it is good to cache this rather than building a new array for
every record...
Using `returnChannel.length == numberOfOutputChannels` makes sense though -
@zhijiangW can you also create a hotfix commit changing this in
`org.apache.flink.streaming.runtime.partitioner.BroadcastPartitioner`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
