fhueske commented on a change in pull request #6606: [FLINK-10163] [sql-client]
Support views in SQL Client
URL: https://github.com/apache/flink/pull/6606#discussion_r212979054
##########
File path:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliClient.java
##########
@@ -420,17 +420,17 @@ private void callCreateView(SqlCommandCall cmdCall) {
final String name = cmdCall.operands[0];
final String query = cmdCall.operands[1];
+ final String previousQuery = context.getViews().get(name);
Review comment:
I think we should not allow to override a view.
It should be explicitly dropped first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
