fhueske commented on a change in pull request #6621: [FLINK-8686] [sql-client]
Limit result size for prototyping modes
URL: https://github.com/apache/flink/pull/6621#discussion_r213012860
##########
File path:
flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/result/MaterializedCollectStreamResult.java
##########
@@ -55,10 +61,21 @@
private boolean isLastSnapshot;
- public MaterializedCollectStreamResult(TypeInformation<Row> outputType,
ExecutionConfig config,
- InetAddress gatewayAddress, int gatewayPort) {
+ public MaterializedCollectStreamResult(
+ TypeInformation<Row> outputType,
+ ExecutionConfig config,
+ InetAddress gatewayAddress,
+ int gatewayPort,
+ long maxRowCount) {
super(outputType, config, gatewayAddress, gatewayPort);
+ if (maxRowCount < 1) {
Review comment:
If disabled (i.e., `< 0`), we could set the parameter to `Integer.MAX_VALUE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
