[
https://issues.apache.org/jira/browse/FLINK-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595333#comment-16595333
]
ASF GitHub Bot commented on FLINK-10233:
----------------------------------------
zentol closed pull request #6624: [FLINK-10233][core] Reverse deprecation of
ConfigOption#withDescription(String)
URL: https://github.com/apache/flink/pull/6624
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
b/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
index be242f54e25..9e6fc324670 100644
--- a/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
+++ b/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java
@@ -125,11 +125,9 @@
*
* @param description The description for this option.
* @return A new config option, with given description.
- * @deprecated use version with {@link Description}
*/
- @Deprecated
public ConfigOption<T> withDescription(final String description) {
- return new ConfigOption<>(key, description, defaultValue,
deprecatedKeys);
+ return
withDescription(Description.builder().text(description).build());
}
/**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Undeprecate ConfigOption#withDescription(String)
> ------------------------------------------------
>
> Key: FLINK-10233
> URL: https://issues.apache.org/jira/browse/FLINK-10233
> Project: Flink
> Issue Type: Improvement
> Components: Configuration, Core
> Affects Versions: 1.7.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> For convenience we should un-deprecate
> {{ConfigOption#withDescription(String)}} and simply forward the call to the
> {{Description}}-based version.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
