pnowojski commented on a change in pull request #6553: [FLINK-10141][network] 
optimisations reducing lock contention
URL: https://github.com/apache/flink/pull/6553#discussion_r213938098
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
 ##########
 @@ -191,16 +191,16 @@ void retriggerSubpartitionRequest(int subpartitionIndex) 
throws IOException, Int
                checkError();
 
                final Buffer next;
-               final int remaining;
+               final boolean moreAvailable;
 
 Review comment:
   nitty nit: replace in commit message 
   
   > [hotfix][network] minor optimisations
   
   with:
   
   > [hotfix][network] Simplify moreAvailable/wasEmpty logic 
   
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to