[
https://issues.apache.org/jira/browse/FLINK-10141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597170#comment-16597170
]
ASF GitHub Bot commented on FLINK-10141:
----------------------------------------
pnowojski commented on a change in pull request #6553: [FLINK-10141][network]
optimisations reducing lock contention
URL: https://github.com/apache/flink/pull/6553#discussion_r213938098
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java
##########
@@ -191,16 +191,16 @@ void retriggerSubpartitionRequest(int subpartitionIndex)
throws IOException, Int
checkError();
final Buffer next;
- final int remaining;
+ final boolean moreAvailable;
Review comment:
nitty nit: replace in commit message
> [hotfix][network] minor optimisations
with:
> [hotfix][network] Simplify moreAvailable/wasEmpty logic
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Reduce lock contention introduced with 1.5
> ------------------------------------------
>
> Key: FLINK-10141
> URL: https://issues.apache.org/jira/browse/FLINK-10141
> Project: Flink
> Issue Type: Bug
> Components: Network
> Affects Versions: 1.5.2, 1.6.0, 1.7.0
> Reporter: Nico Kruber
> Assignee: Nico Kruber
> Priority: Major
> Labels: pull-request-available
>
> With the changes around introducing credit-based flow control as well as the
> low latency changes, unfortunately, we also introduced some lock contention
> on {{RemoteInputChannel#bufferQueue}} and
> {{RemoteInputChannel#receivedBuffers}} as well as asking for queue sizes when
> the only thing we need is whether it is empty or not.
> This was observed as a high idle CPU load with no events in the stream but
> only watermarks (every 500ms) and many slots on a single machine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
