dawidwys commented on issue #6632: [FLINK-10254][backend]Fix inappropriate 
checkNotNull in stateBackend
URL: https://github.com/apache/flink/pull/6632#issuecomment-417290047
 
 
   What I meant is: Why have you decided to open this PR? Have you came across 
any problems with the check as it is currently in master? Before even analyzing 
a PR we should have a clear picture what is the reason for a change to be able 
to properly prioritize an important changes from not so much, but still 
requiring an effort of reviewing, verifying etc.
   
   As far as I understand this is an isolated, internal component and a similar 
check is done one layer upwards. That's why I would really like to understand 
the reason for this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to