[
https://issues.apache.org/jira/browse/FLINK-10254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16597514#comment-16597514
]
ASF GitHub Bot commented on FLINK-10254:
----------------------------------------
Aitozi commented on issue #6632: [FLINK-10254][backend]Fix inappropriate
checkNotNull in stateBackend
URL: https://github.com/apache/flink/pull/6632#issuecomment-417339692
I didn't run into a problem, but when i review the code locally, i found
that a checkNotNull do nothing to a primitive int value.It's indeed checked
upwards, but i think its here for defensive code, so i push a little change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Fix inappropriate checkNotNull in stateBackend
> ----------------------------------------------
>
> Key: FLINK-10254
> URL: https://issues.apache.org/jira/browse/FLINK-10254
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.6.0
> Reporter: aitozi
> Assignee: aitozi
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.6.0
>
>
> The checkNotNull is unnecessary of numberOfKeyGroups with a primitive type ,
> we just have to make sure it is bigger than 1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
